Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark wpt/test-user-timing test flaky #41203

Closed
wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

  • The RH team had a team day looking at helping move
    the CI closer to green. This is one of the flaky tests
    with the most reported failures and has been open
    since October. Marking flaky.

Signed-off-by: Michael Dawson mdawson@devrus.com

- The RH team had a team day looking at helping move
  the CI closer to green. This is one of the flaky tests
  with the most reported failures and has been open
  since October. Marking flaky.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 16, 2021
@lpinca
Copy link
Member

lpinca commented Dec 16, 2021

I think it makes sense to mark it flaky on all platforms.

@mhdawson
Copy link
Member Author

@lpinca updated.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2021
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41203
✔  Done loading data for nodejs/node/pull/41203
----------------------------------- PR info ------------------------------------
Title      test: mark wpt/test-user-timing test flaky (#41203)
Author     Michael Dawson  (@mhdawson)
Branch     mhdawson:mark-flaky -> nodejs:master
Labels     test, needs-ci
Commits    2
 - test: mark wpt/test-user-timing test flaky
 - Update wpt.status
Committers 2
 - Michael Dawson 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/41203
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Adrian Estrada 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41203
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Adrian Estrada 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 16 Dec 2021 19:05:42 GMT
   ✔  Approvals: 3
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41203#pullrequestreview-834530822
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41203#pullrequestreview-835346797
   ✔  - Adrian Estrada (@edsadr): https://github.com/nodejs/node/pull/41203#pullrequestreview-835411926
   ✔  Last GitHub Actions successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1598856323

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 19, 2021
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@mhdawson
Copy link
Member Author

Landed in 555e7f9

@mhdawson mhdawson closed this Dec 22, 2021
mhdawson added a commit that referenced this pull request Dec 22, 2021
- The RH team had a team day looking at helping move
  the CI closer to green. This is one of the flaky tests
  with the most reported failures and has been open
  since October. Marking flaky.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41203
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
targos pushed a commit that referenced this pull request Jan 14, 2022
- The RH team had a team day looking at helping move
  the CI closer to green. This is one of the flaky tests
  with the most reported failures and has been open
  since October. Marking flaky.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41203
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
- The RH team had a team day looking at helping move
  the CI closer to green. This is one of the flaky tests
  with the most reported failures and has been open
  since October. Marking flaky.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41203
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
- The RH team had a team day looking at helping move
  the CI closer to green. This is one of the flaky tests
  with the most reported failures and has been open
  since October. Marking flaky.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#41203
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
- The RH team had a team day looking at helping move
  the CI closer to green. This is one of the flaky tests
  with the most reported failures and has been open
  since October. Marking flaky.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #41203
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants